format: airbyte-ci format fix all on PR / airbyte-ci format check all on master
#32491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
alafanechere
changed the title
airbyte-ci format fix all on PR from airbyte-ci format check all on masterairbyte-ci format fix all on PR / airbyte-ci format check all on master
| @@ -1,4 +1,4 @@ | |||
| name: Check for formatting errors | |||
| name: Automatic Formatting on PRs | |||
There was a problem hiding this comment.
You're going to want to follow the "fix" with a "check". Not everything can always be fixed automatically and formatting errors should be caught before the PR is merged. In fact, that's the DoD for this whole initiative.
There was a problem hiding this comment.
Done in 715a8e0
| @@ -0,0 +1,59 @@ | |||
| name: Check for formatting errors on head ref | |||
There was a problem hiding this comment.
Not a blocking comment but in the near future we're going to want to subsume a larger class of checks than just formatting checks in this workflow, so its name should reflect that.
There was a problem hiding this comment.
I'd prefer keeping this name as it is as we don't know yet what's going to be in this "larger class of checks" and we might want to split them in multiple workflows
alafanechere
force-pushed
the
augustin/11-14-format_airbyte-ci_format_fix_all_on_PR_from_airbyte-ci_format_check_all_on_master
branch
from
e656bcb to
715a8e0
Compare
alafanechere
deleted the
augustin/11-14-format_airbyte-ci_format_fix_all_on_PR_from_airbyte-ci_format_check_all_on_master
branch
What
I think we want two separate worfklows for
format:masterand yells in slack if something is not formatted onmasterHow
format.ymlin two worfklowsformat_fix.yml: Runsairbyte format fix allon PRs + commit changesformat_check.yml: Runsairbyte format check allon merge to master and sends a slack message in case of failure.